opensoul.org

My First Rails Core Contribution

After spending the better part of the day trying to figure out why my .rpdf template handler was generating blank PDFs yesterday, only to realize that it was trying to render them inside the default HTML layout, I submitted a small patch to the Rails Trac to allow other file extensions—in addition to .rjs—to be exempt from being rendered in the layout. Having submitted other patches in the past, I fully expected this patch to be ignored for a few months, or indefinitely.

But to my surprise, I opened up my news reader this morning to find changeset 5126: Declare file extensions exempt from layouts.

rails September 16, 2006

2 Comments

  1. Mark Van Holstyn Mark Van Holstyn September 16, 2006

    Nice work! I saw that ticket and changeset and liked it! I also just used the .rpdf templates this week and that will work well for me! Thanks!

  2. Pat Eyler Pat Eyler September 16, 2006

    Good work Brandon! Keep this up and you’ll get a commit bit in no time. ;^)

Post a Comment

Comments use textile. Anonymous comments will be deleted.

My name is Brandon Keepers. I like to build things, usually in Ruby or JavaScript. I work at GitHub and live in Holland, MI.

Popular Posts